Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum Python version for pylint #10318

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

jakelishman
Copy link
Member

Summary

This got missed during 4dfef13, and is needed to avoid Pylint complaining about standard-library features that were added after the minimum version it thinks we're on.

Details and comments

See also #10009.

This got missed during 4dfef13, and is needed to avoid Pylint
complaining about standard-library features that were added after the
minimum version it thinks we're on.
@jakelishman jakelishman added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Jun 21, 2023
@jakelishman jakelishman added this to the 0.25.0 milestone Jun 21, 2023
@jakelishman jakelishman requested a review from a team as a code owner June 21, 2023 12:03
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@mtreinish mtreinish enabled auto-merge June 21, 2023 12:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5333802088

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 85.952%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 1 90.89%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 1 90.39%
crates/qasm2/src/parse.rs 6 97.58%
Totals Coverage Status
Change from base Build 5325838354: -0.01%
Covered Lines: 71344
Relevant Lines: 83004

💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Jun 21, 2023
Merged via the queue into Qiskit:main with commit 924702e Jun 21, 2023
@jakelishman jakelishman deleted the update-pylint-version branch June 21, 2023 16:23
@levbishop
Copy link
Member

We should probably have a place where we document all the spots that need changing every time we bump python version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants