Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated InstructionSet circuit_cregs argument #10302

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Remove deprecated InstructionSet circuit_cregs argument #10302

merged 1 commit into from
Jun 16, 2023

Conversation

mtreinish
Copy link
Member

@mtreinish mtreinish commented Jun 16, 2023 •
edited
Loading

Summary

This commit removes the deprecated circuit_cregs argument from the InstructionSet class. This argument was deprecated in the 0.19.0 release and has been superseded by the resource_requester.

Details and comments

@mtreinish
Remove deprecated InstructionSet circuit_cregs argument
2fc8e8c 
This commit removes the deprecated circuit_cregs argument from the
InstructionSet class. This argument was deprecated in the 0.19.0
release and has been supersceded by the resource_requester.
@mtreinish mtreinish added the Changelog: Removal Include in the Removed section of the changelog label Jun 16, 2023
@mtreinish mtreinish added this to the 0.25.0 milestone Jun 16, 2023
@mtreinish mtreinish requested a review from a team as a code owner June 16, 2023 18:51
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5293263673

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 14 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.01%) to 85.97%
Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 1 90.39%
qiskit/extensions/quantum_initializer/squ.py 2 80.0%
crates/qasm2/src/lex.rs 5 91.39%
crates/qasm2/src/parse.rs 6 97.58%
Totals Coverage Status
Change from base Build 5290636728: -0.01%
Covered Lines: 71477
Relevant Lines: 83142
💛 - Coveralls

jakelishman
jakelishman approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@jakelishman jakelishman added this pull request to the merge queue Jun 16, 2023
Merged via the queue into Qiskit:main with commit c186695 Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

Assignees
No one assigned
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mtreinish @qiskit-bot @coveralls @jakelishman