Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove list argument broadcasting and simplify transpile() #10291
Remove list argument broadcasting and simplify transpile() #10291
Changes from 6 commits
094fb0f
e416792
99ee51a
9becdfb
a8b51a7
34cb5e3
2d20bdb
b5ded69
88abdb0
3cfb059
bb91c43
966003b
ad0e404
8a04ed3
a1f7072
ffd1019
0ea2eda
75c918b
87df8cc
04bcd2c
a47e108
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the new error message significantly worse?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was when I modified this test, but @1ucian0 added a real error message in
SetLayout
as part of #10344 so it'll say:now. (I glossed over
<>
in my review we should change that to actually say1024 qubits in the layout != 2 qubits in the circuit
or something more explicit instead)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or just stick
from __future__ import barry_as_FLUFL
at the top of the file lol