-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix output of DensityMatrix.partial_transpose
to match input dimensions
#10163
Conversation
…hing input dimensions
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
lmk if tests to check for dims are needed. |
Yeah, a short test and a bugfix release note would be great, please! |
Pull Request Test Coverage Report for Build 5188549547
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for finding and fixing the bug. Great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…ions (#10163) * (fix) change output of partial_transpose to return DensityMatrix matching input dimensions * (test) check output dims match input dims when using DensityMatrix.partial_transpose * (docs) add bugfix reno * lint changes * Fix up release note --------- Co-authored-by: Jake Lishman <[email protected]> (cherry picked from commit 6f29d7b)
…ions (#10163) (#10215) * (fix) change output of partial_transpose to return DensityMatrix matching input dimensions * (test) check output dims match input dims when using DensityMatrix.partial_transpose * (docs) add bugfix reno * lint changes * Fix up release note --------- Co-authored-by: Jake Lishman <[email protected]> (cherry picked from commit 6f29d7b) Co-authored-by: Diego Emilio Serrano <[email protected]>
Summary
Add dimensions to the
DensityMatrix
returned bypartial_transpose
so its dimensions match those of the input density matrix.Details and comments
Fix #10155