-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dispatch a builder with backendV1 and backendV2 #10150
Merged
nkanazawa1989
merged 25 commits into
Qiskit:main
from
to24toro:feature/dispatch_backend
Jun 12, 2023
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
6a3b145
fix measure_v2
to24toro 3cd1192
modify measure_all
to24toro 58023f5
dispatch backend
to24toro 93a9262
add test of the builder with backendV2
to24toro 2cc5451
reconfigure test codes and some func
to24toro a21cc84
refactoring
to24toro b3607ee
add reno
to24toro bd1e169
fix _measure_v2
to24toro d70796f
fix backend.meas_map in measure_v2
to24toro 2a651dd
fix reno
to24toro 8d92531
delete get_qubit_channels from utils
to24toro 9b2b80d
add get_qubits_channels in qubit_channels
to24toro 891c1bd
recostruct test about the builder with backendV2
to24toro 1d3b471
Merge branch 'main' into feature/dispatch_backend
to24toro a6363c3
fix descriptions of test_macros
to24toro 3aeba17
fix descriptions of test_macros again
to24toro f3127df
Merge branch 'main' into feature/dispatch_backend
to24toro 9fee85e
delete import of backendV2 in utils
to24toro c8d13f5
revert no need to modify code
to24toro fecdcae
Update releasenotes/notes/fix-dispatching-backends-28aff96f726ca9c5.yaml
to24toro f0ee72f
Merge remote-tracking branch 'origin/feature/dispatch_backend' into f…
to24toro c7a36dc
Update a commnet in qiskit/pulse/builder.py
to24toro 117931d
Merge branch 'main' into feature/dispatch_backend
to24toro 817d04a
remove import TYPE_CHECKING
to24toro 0e204eb
removed test_builder.py utils.py and test_analyzation.py from pull re…
to24toro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
releasenotes/notes/fix-dispatching-backends-28aff96f726ca9c5.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
--- | ||
fixes: | ||
- | | ||
Fixed an failure of the pulse builder when the context is initialized with :class:`.BackendV2`. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this logic to get dt everywhere in this file. This is of course not the scope of this PR, but could you please add new builder command to get backend dt in 0.25 for cleanup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want me to add like below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, in the followup PR for 0.25. I think this makes some logic cleaner.