Fix BasicSwap FakeRun Typo

[evmckinney9]

Summary

Resolve #10147

Details and comments

Reference the function instead of the attribute.

[evmckinney9]

I checked other files, didn't see a similar mistake.

[qiskit-bot]

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

• @Qiskit/terra-core

[Cryoris]

Thanks for the fix! Could you add a test that verifies this behavior is fixed now (in the basic swap test file) and a releasenote documenting this fix? See e.g. the contributing guidelines for some more details and let us know if we can help you with that!

[1ucian0]

Thanks for the fix! Do you mind adding a test to show the bug that this is fixing?

[coveralls]

Pull Request Test Coverage Report for Build 5081968106

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• 50 unchanged lines in 9 files lost coverage.
• Overall coverage increased (+0.05%) to 85.968%

---

Files with Coverage Reduction	New Missed Lines	%
qiskit/transpiler/layout.py	1	94.08%
crates/accelerate/src/vf2_layout.rs	3	94.74%
qiskit/transpiler/passes/calibration/rzx_builder.py	3	89.53%
crates/accelerate/src/sabre_swap/layer.rs	4	97.32%
qiskit/circuit/library/generalized_gates/rv.py	4	85.19%
crates/qasm2/src/lex.rs	5	90.63%
qiskit/converters/init.py	5	73.08%
crates/qasm2/src/parse.rs	6	97.58%
qiskit/compiler/transpiler.py	19	90.12%

Totals
Change from base Build 5059475398:	0.05%
Covered Lines:	71356
Relevant Lines:	83003

---

💛 - Coveralls

[jakelishman]

Thanks for looking at this! I have one thing about the test, but after that we'll be good to merge.

[evmckinney9]

Oops, seems I messed things up by moving around my fork's branches.

[jakelishman]

No worries, it's not a problem. In case you weren't sure, this is why it's not generally recommended to make PRs from your main branch - GitHub will let you because of its fork+PR process, but it's pretty easy to get the branches tangled.