-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BasicSwap FakeRun Typo #10149
Fix BasicSwap FakeRun Typo #10149
Conversation
I checked other files, didn't see a similar mistake. |
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Thanks for the fix! Could you add a test that verifies this behavior is fixed now (in the basic swap test file) and a releasenote documenting this fix? See e.g. the contributing guidelines for some more details and let us know if we can help you with that! |
Thanks for the fix! Do you mind adding a test to show the bug that this is fixing? |
Pull Request Test Coverage Report for Build 5081968106
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking at this! I have one thing about the test, but after that we'll be good to merge.
Oops, seems I messed things up by moving around my fork's branches. |
No worries, it's not a problem. In case you weren't sure, this is why it's not generally recommended to make PRs from your |
* fix typo, issue #10147 * create basicswap fake_run test * release note for #10149 fix * ensure fake_run modifes layout prop, not the circuit logic * black formatting, test_basic_swap (cherry picked from commit 7df290b) Co-authored-by: Evan McKinney <[email protected]>
Summary
Resolve #10147
Details and comments
Reference the function instead of the attribute.