Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define __getstate__ and __setstate__ for OneQubitGateErrorMap #10092

Merged
merged 5 commits into from
May 10, 2023
Merged

define __getstate__ and __setstate__ for OneQubitGateErrorMap #10092

merged 5 commits into from
May 10, 2023

Conversation

kevinsung
Copy link
Contributor

Summary

Fixes #10091

Details and comments

@kevinsung kevinsung requested a review from a team as a code owner May 9, 2023 20:38
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

Eric-Arellano
Eric-Arellano previously approved these changes May 9, 2023
View reviewed changes
mtreinish
mtreinish reviewed May 9, 2023
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this LGTM, just one small comment in the tests. Also do you mind adding a release note so we can document this fix when we publish 0.24.1?

test/python/compiler/test_transpiler.py Outdated Show resolved Hide resolved
@mtreinish mtreinish added Changelog: Bugfix Include in the "Fixed" section of the changelog Rust This PR or issue is related to Rust code in the repository labels May 9, 2023
@mtreinish mtreinish added this to the 0.24.1 milestone May 9, 2023
@coveralls
Copy link

coveralls commented May 9, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4931482641

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 64 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.006%) to 85.92%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 1 91.9%
qiskit/circuit/tools/pi_check.py 1 91.23%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 1 90.46%
qiskit/pulse/library/waveform.py 3 93.75%
qiskit/transpiler/passes/scheduling/alignments/reschedule.py 3 96.15%
qiskit/visualization/gate_map.py 55 83.33%
Totals Coverage Status
Change from base Build 4928810679: 0.006%
Covered Lines: 71163
Relevant Lines: 82825
💛 - Coveralls

@kevinsung
Copy link
Contributor Author

release note added, comment addressed

@mtreinish mtreinish added the stable backport potential The bug might be minimal and/or import enough to be port to stable label May 10, 2023
mtreinish
mtreinish approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick update

@mtreinish mtreinish added this pull request to the merge queue May 10, 2023
Merged via the queue into Qiskit:main with commit 06a5b9e May 10, 2023
mergify bot pushed a commit that referenced this pull request May 10, 2023
@kevinsung @mergify
define __getstate__ and __setstate__ for OneQubitGateErrorMap (#10092)
aaaddee 
* define __getstate__ and __setstate__ for OneQubitGateErrorMap

* add test

* fix test docstrings

* add assert in test

* add release note

(cherry picked from commit 06a5b9e)
@mergify mergify bot mentioned this pull request May 10, 2023
Merged
@kevinsung kevinsung deleted the transpile-one-q-pickle branch May 10, 2023 13:17
mtreinish pushed a commit that referenced this pull request May 10, 2023
@mergify @kevinsung
define __getstate__ and __setstate__ for OneQubitGateErrorMap (#10092) (
99b1569 
#10095)

* define __getstate__ and __setstate__ for OneQubitGateErrorMap

* add test

* fix test docstrings

* add assert in test

* add release note

(cherry picked from commit 06a5b9e)

Co-authored-by: Kevin J. Sung <[email protected]>
king-p3nguin pushed a commit to king-p3nguin/qiskit-terra that referenced this pull request May 22, 2023
@kevinsung @king-p3nguin
define __getstate__ and __setstate__ for OneQubitGateErrorMap (Qiskit…
c95b654 
…#10092)

* define __getstate__ and __setstate__ for OneQubitGateErrorMap

* add test

* fix test docstrings

* add assert in test

* add release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

@Eric-Arellano Eric-Arellano Eric-Arellano left review comments

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog Rust This PR or issue is related to Rust code in the repository stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
0.24.1
Development

Successfully merging this pull request may close these issues.

TypeError: cannot pickle 'builtins.OneQubitGateErrorMap' object
5 participants
@kevinsung @qiskit-bot @coveralls @mtreinish @Eric-Arellano