Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the qubit_coordinates_map for ibm_seattle #10089

Merged
merged 2 commits into from
May 9, 2023
Merged

Add the qubit_coordinates_map for ibm_seattle #10089

merged 2 commits into from
May 9, 2023

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented May 9, 2023

The new IBM's ibm_seattle is big. Very big. And plot_gate_map(ibm_seattle) returns things like this:

image

This is because there is no qubit_coordinates_map for 433 qubits. This PR adds it.

image

@1ucian0 1ucian0 requested review from a team and nonhermitian as code owners May 9, 2023 09:59
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

@1ucian0 1ucian0 added this to the 0.24.1 milestone May 9, 2023
@1ucian0 1ucian0 added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: Bugfix Include in the "Fixed" section of the changelog labels May 9, 2023
@1ucian0 1ucian0 changed the title add ibm_seattle qubit_coordinates_map Add the qubit_coordinates_map for ibm_seattle May 9, 2023
@coveralls
Copy link

coveralls commented May 9, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4929976457

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 85 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.04%) to 85.874%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.76%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 1 90.46%
crates/accelerate/src/sabre_swap/mod.rs 2 99.53%
crates/qasm2/src/lex.rs 2 90.63%
qiskit/qasm/node/unaryoperator.py 2 70.59%
qiskit/qasm/node/prefix.py 3 52.17%
crates/qasm2/src/parse.rs 12 96.65%
qiskit/circuit/quantumcircuit.py 62 94.07%
Totals Coverage Status
Change from base Build 4919025971: 0.04%
Covered Lines: 71052
Relevant Lines: 82740
💛 - Coveralls

kdk
kdk reviewed May 9, 2023
View reviewed changes
Copy link
Member

@kdk kdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One docs release note comment, LGTM otherwise.

releasenotes/notes/433_qubit_coordinates_map-8abc318fefdb99ac.yaml Outdated Show resolved Hide resolved
@kdk kdk enabled auto-merge May 9, 2023 20:35
@kdk kdk added this pull request to the merge queue May 9, 2023
Merged via the queue into Qiskit:main with commit 7a215f9 May 9, 2023
mergify bot pushed a commit that referenced this pull request May 9, 2023
@1ucian0 @mergify
Add the qubit_coordinates_map for ibm_seattle (#10089)
1ace513 
* add ibm_seattle qubit_coordinates_map

* Update releasenotes/notes/433_qubit_coordinates_map-8abc318fefdb99ac.yaml

Co-authored-by: Kevin Krsulich <[email protected]>

---------

Co-authored-by: Kevin Krsulich <[email protected]>
(cherry picked from commit 7a215f9)
@mergify mergify bot mentioned this pull request May 9, 2023
Merged
mtreinish pushed a commit that referenced this pull request May 10, 2023
@mergify @1ucian0
Add the qubit_coordinates_map for ibm_seattle (#10089) (#10094)
ce360b5 
* add ibm_seattle qubit_coordinates_map

* Update releasenotes/notes/433_qubit_coordinates_map-8abc318fefdb99ac.yaml

Co-authored-by: Kevin Krsulich <[email protected]>

---------

Co-authored-by: Kevin Krsulich <[email protected]>
(cherry picked from commit 7a215f9)

Co-authored-by: Luciano Bello <[email protected]>
king-p3nguin pushed a commit to king-p3nguin/qiskit-terra that referenced this pull request May 22, 2023
@1ucian0 @kdk @king-p3nguin
Add the qubit_coordinates_map for ibm_seattle (Qiskit#10089)
450284e 
* add ibm_seattle qubit_coordinates_map

* Update releasenotes/notes/433_qubit_coordinates_map-8abc318fefdb99ac.yaml

Co-authored-by: Kevin Krsulich <[email protected]>

---------

Co-authored-by: Kevin Krsulich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish left review comments

@kdk kdk kdk approved these changes

@nonhermitian nonhermitian Awaiting requested review from nonhermitian nonhermitian is a code owner

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
0.24.1
Development

Successfully merging this pull request may close these issues.
5 participants
@1ucian0 @qiskit-bot @coveralls @kdk @mtreinish