-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QuantumCircuit initialize() links to StatePreparation and Initialize need fixing #11611
Comments
Hi @woodsp-ibm can I be assigned to this issue? |
Ah yeah, that was overlooked in #10725, nice catch! @valleyofblackpanther of course, you can have a go at it! The links pointing to |
Hi, @Cryoris I made the changes but I am unable to push them because Qiskit is not allowing me to do so, do I have to sign the CLA agreement, before pushing it to the main? And who should I send signed document too? |
Hi, you cannot push changes direct into the repository if that is what you are trying to do. Rather you should fork the repo, then make a new branch off the branch to which the changes should apply in your repo, make the changes on that branch in your fork and then do a PR (Pull Request). The CLA is online and when doing a PR it will link to this for it to be signed electronically. here is more info about these things in this file https://github.com/Qiskit/qiskit/blob/main/CONTRIBUTING.md if you have not seen this. While the typo (the missing 'y' can be fixed with a PR against main (i,e do the changes in a new branch made from main branch), I think the issue against 0.46 needs to be done against the stable/0.46 branch. There do not seem to be any more releases planned for 0.45 so it maybe 0.46 (which is imminent anyway) is the earliest it can be fixed for, with 1.0 coming a bit later from main. Hopefully @Cryoris can correct me if needed. |
…Preparation and Initialize need fixing
…anged it to circut.library Fixed on Qiskit#11611 QuantumCircuit initialize() links to StatePreparation and Initialize need fixing
Hi @Cryoris @woodsp-ibm I did the required changes as instructed. |
…ation and Initialize need fixing (#11631)
* QuantumCircuit initialize - the links are referring to extensions, changed it to circut.library Fixed on #11611 QuantumCircuit initialize() links to StatePreparation and Initialize need fixing * Fix doc links to qiskit.extensions #11632, truncate displayed path by adding a ~ * Fix doc links to qiskit.extensions #11632, truncate displayed path by adding a ~ and QuantumCircuit initialize - the links are referring to extensions changed it to circut.library
This issues have been fixed by referenced PRs so I am closing this (not sure why it was not auto-closed). |
I was looking at the published docs for QuantumCircuit initialize - the links are referring to
extensions
and do not resolvehttps://docs.quantum.ibm.com/api/qiskit/qiskit.circuit.QuantumCircuit#initialize
which is in
0.45
and0.46
qiskit/qiskit/circuit/quantumcircuit.py
Lines 4113 to 4117 in f078b64
qiskit.extensions
#11632In
main
it seems to have been updated but there is a typo in the StatePreparation link - library
is missing they
thereqiskit/qiskit/circuit/quantumcircuit.py
Lines 4562 to 4566 in a7fa6c5
QuantumCircuit.initialize
#11631The text was updated successfully, but these errors were encountered: