Skip to content

Commit

Permalink
Pin jupyter-core to < 5.0.0 (backport #9105) (#9120)
Browse files Browse the repository at this point in the history
* Pin jupyter-core to < 5.0.0 (#9105)

The recent release of jupyter-core 5.0.0 started emitting a deprecation
warning during the image comparison tests which is causing a failure
caused by usage in seasborn via ipywidgets. To workaround this in the
short term this commit set a constraint on the jupyter-core version. We
should remove this pin after seaborn and ipywidgets are updated, or we
add an explicit warning exclude to the test suite.

(cherry picked from commit 29c56a3)

# Conflicts:
#	constraints.txt

* Fix merge conflicts

Co-authored-by: Matthew Treinish <[email protected]>
  • Loading branch information
mergify[bot] and mtreinish authored Nov 11, 2022
1 parent b2c75ac commit 7b4afa5
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions constraints.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,8 @@ pyparsing<3.0.0
# to work with the new jinja version (the jinja maintainers aren't going to
# fix things) pin to the previous working version.
jinja2==3.0.3

# jupyter-core 5.0.0 started emitting deprecation warnings with ipywidgets via
# a seaborn import. This pin can be removed when compatibility with those
# packages is fixed
jupyter-core==4.11.2

0 comments on commit 7b4afa5

Please sign in to comment.