Add checks for parameter expressions with gen3-turbo runtime. #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The linting failures appear spurious to me. I will need to look into how to get pylint to accept these lines. |
ihincks
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
These changes and tests look correct to me, thanks @blakejohnson .
At some point we'll need to profile all of these isinstance checks that are piling up through validation...out of scope.
kt474
added
the
Changelog: New Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds client-side checks to the Sampler and Estimator to ensure that circuits with
ParameterExpressions are not used in combination with"execution_path": "gen3-turbo".