Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast forward experimental-0.2 to the latest main #1248

Merged
merged 17 commits into from
Dec 1, 2023

Conversation

jyu00
Copy link
Collaborator

@jyu00 jyu00 commented Nov 30, 2023

Summary

Details and comments

Fixes #

ElePT and others added 17 commits November 16, 2023 12:07
)

* Migrate fake provider

* fix lint

* Only migrate backends and fake_provider file to minimize duplication

* Add reno

* Update snippet to use runtime service

---------

Co-authored-by: Kevin Tian <[email protected]>
* try/except raw result truncation

* catch typeError

* revert try/except, use response.text

* update unit test
* Clean up/fix integration test

* Update test case

* Fix black
* Added deprecation warning when using qiskitrc file

* Fixed bug whereby deprecation warnings cause failure for all 'qiskit*' modules. Changed warning to deprecation warning.

* Release note

* Small grammer fix

* black

---------

Co-authored-by: Kevin Tian <[email protected]>
* update session.from_id()

* add deprecation warning

* add reno
* Revert "Update session.from_id() (Qiskit#1163)"

This reverts commit 8fa0472.

* add reno
* initial removal

* cleanup more files

* move result_decoder

* fix lint

* update unit tests

* update integration tests

* more docs changes

* release note

* fix path

---------

Co-authored-by: Jessie Yu <[email protected]>
* Make sessions thread safe.

The lock prevents other threads from sending new jobs to the service
only if the session hasnot been setup yet. I.e.: when sending the
first "session starter job", or root job. After this happens, the code
is left unlocked to allow threads to access the service concurrently.

Error handling is needed to ensure the lock is always released.

* Allow multiple sessions to execute simultaneously

* Make session test more deterministic

---------

Co-authored-by: Kevin Tian <[email protected]>
Co-authored-by: Jessie Yu <[email protected]>
* compare cloud instance with channel strategy

* fix unit tests

* error wording

---------

Co-authored-by: Jessie Yu <[email protected]>
* release notes

* fix release
@jyu00 jyu00 requested a review from kt474 November 30, 2023 18:23
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7050668129

  • 25 of 1005 (2.49%) changed or added relevant lines in 111 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-8.4%) to 51.918%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/api/clients/runtime.py 1 2 50.0%
qiskit_ibm_runtime/qiskit_runtime_service.py 4 5 80.0%
qiskit_ibm_runtime/runtime_job.py 1 2 50.0%
qiskit_ibm_runtime/session.py 12 13 92.31%
qiskit_ibm_runtime/fake_provider/backends/auckland/init.py 0 2 0.0%
qiskit_ibm_runtime/fake_provider/backends/geneva/init.py 0 2 0.0%
qiskit_ibm_runtime/fake_provider/backends/oslo/init.py 0 2 0.0%
qiskit_ibm_runtime/fake_provider/backends/perth/init.py 0 2 0.0%
qiskit_ibm_runtime/fake_provider/backends/prague/init.py 0 2 0.0%
qiskit_ibm_runtime/fake_provider/backends/rueschlikon/init.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
qiskit_ibm_runtime/utils/json.py 1 75.25%
qiskit_ibm_runtime/runtime_job.py 2 73.65%
qiskit_ibm_runtime/qiskit_runtime_service.py 4 79.19%
Totals Coverage Status
Change from base Build 7048937877: -8.4%
Covered Lines: 3100
Relevant Lines: 5971

💛 - Coveralls

@jyu00 jyu00 merged commit 2a39617 into Qiskit:experimental-0.2 Dec 1, 2023
17 checks passed
@jyu00 jyu00 deleted the fast-forward branch December 1, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants