Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Build wheels first in development version tests #31

Merged
merged 7 commits into from
Sep 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,8 @@ jobs:
sed -i.bak -e '/unreleased_version_title:*/d' releasenotes/config.yaml
echo unreleased_version_title: \"Upcoming release \(\`\`${GITHUB_REF_NAME}\`\`\)\" >> releasenotes/config.yaml
- name: Build docs
shell: bash
run: |
tox -edocs
tox -e docs
- name: Upload docs artifact for GitHub Pages
uses: actions/upload-pages-artifact@v3
with:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,5 @@ jobs:
python -m pip install --upgrade pip
pip install tox
- name: Run lint check
shell: bash
run: |
tox -elint
tox -e lint
46 changes: 21 additions & 25 deletions .github/workflows/test_development_versions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,32 +28,28 @@ jobs:
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Determine development versions
shell: bash
run: |
# NOTE: by determining the current git commit SHAs, we can ensure that
# the individually run tox environments indeed actually use the exact
# same versions (which may not be the case if at the exact time a new
# commit gets added to the respective repositories).
# Additionally, using these commit SHAs ensures that the locally built
# Python wheels get cached, ensuring a faster tox environment setup
# for the multiple jobs below.
QISKIT_SHA=$(git ls-remote "https://github.com/Qiskit/qiskit" | grep HEAD | awk '{print $1}')
echo "QISKIT_SHA=$QISKIT_SHA" >> "$GITHUB_ENV"
echo "Using Qiskit/qiskit @ $QISKIT_SHA"
QISKIT_IBM_RUNTIME_SHA=$(git ls-remote "https://github.com/Qiskit/qiskit-ibm-runtime" | grep HEAD | awk '{print $1}')
echo "QISKIT_IBM_RUNTIME_SHA=$QISKIT_IBM_RUNTIME_SHA" >> "$GITHUB_ENV"
echo "Using Qiskit/qiskit-ibm-runtime @ $QISKIT_IBM_RUNTIME_SHA"
- name: Pinning development versions
shell: bash
- name: Upgrade pip
run: |
python -m pip install --upgrade pip
python -m pip install tox extremal-python-dependencies==0.0.3
extremal-python-dependencies pin-dependencies \
"qiskit @ git+https://github.com/Qiskit/qiskit.git@$QISKIT_SHA" \
"qiskit-ibm-runtime @ git+https://github.com/Qiskit/qiskit-ibm-runtime.git@$QISKIT_IBM_RUNTIME_SHA" \
--inplace
- name: Test using tox environment
- name: Install tools from pypi
run: |
python -m pip install tox build extremal-python-dependencies==0.0.3
- name: Build Qiskit SDK development wheel
run: |
git clone https://github.com/Qiskit/qiskit
cd qiskit
python -m build --wheel
- name: Build qiskit-ibm-runtime development wheel
run: |
git clone https://github.com/Qiskit/qiskit-ibm-runtime
cd qiskit-ibm-runtime
python -m build --wheel
- name: Pin development versions
shell: bash
run: >-
extremal-python-dependencies pin-dependencies --inplace
"qiskit @ file:$(echo qiskit/dist/*.whl)"
"qiskit-ibm-runtime @ file:$(echo qiskit-ibm-runtime/dist/*.whl)"
- name: Test using tox environment
run: |
tox -e py,notebook,doctest
tox -e py,notebook,doctest --parallel --parallel-no-spinner
1 change: 0 additions & 1 deletion .github/workflows/test_minimum_versions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,5 @@ jobs:
pip install "tox==$(extremal-python-dependencies get-tox-minversion)"
extremal-python-dependencies pin-dependencies-to-minimum --inplace
- name: Test using tox environment
shell: bash
run: |
tox -e py,notebook,doctest --parallel --parallel-no-spinner