Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a coloring how-to #30

Merged
merged 18 commits into from
Sep 13, 2024
Merged

Add a coloring how-to #30

merged 18 commits into from
Sep 13, 2024

Conversation

caleb-johnson
Copy link
Collaborator

This PR adds a how-to showing how coloring can be used to improve the depth of circuits by more efficiently placing gates.

Co-authored-by: Max Rossmannek <[email protected]>
@coveralls
Copy link

coveralls commented Sep 12, 2024

Pull Request Test Coverage Report for Build 10844302431

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 10832955808: 0.0%
Covered Lines: 297
Relevant Lines: 297

💛 - Coveralls

@caleb-johnson caleb-johnson added the stable backport potential Label for mergify to open a backport PR label Sep 12, 2024
@caleb-johnson
Copy link
Collaborator Author

@mrossinek I can probably get graphviz installed in the CI envs, but I'm a bit confused why OBP can use graphviz_draw in the notebooks using the same type of dependency specification of rustworkx[graphviz] that I do here.

Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like this, thanks for putting it together!

Just some nitpicky ideas 👍

@mrossinek mrossinek enabled auto-merge (squash) September 13, 2024 06:40
@mrossinek mrossinek merged commit 7c42e3c into main Sep 13, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request Sep 13, 2024
* Add a coloring how-to

Co-authored-by: Max Rossmannek <[email protected]>

* style

* lint

* Add runtime to notebook deps for fake backends

* Get graphviz with rustworkx

* fix duplicate

* Clean up tutorial

* Skip graphviz cells for execution

* style :)

* Didn't save second metadata change

* Evidently one of the tags wasn't checked? *sigh*

* peer review

* style

* that/which pedantry

* rephrase

* Improve output

* Use single quotes

* docs: use slice_by_depth in colored circuit, too

---------

Co-authored-by: Max Rossmannek <[email protected]>
(cherry picked from commit 7c42e3c)
mrossinek pushed a commit that referenced this pull request Sep 13, 2024
* Add a coloring how-to

Co-authored-by: Max Rossmannek <[email protected]>

* style

* lint

* Add runtime to notebook deps for fake backends

* Get graphviz with rustworkx

* fix duplicate

* Clean up tutorial

* Skip graphviz cells for execution

* style :)

* Didn't save second metadata change

* Evidently one of the tags wasn't checked? *sigh*

* peer review

* style

* that/which pedantry

* rephrase

* Improve output

* Use single quotes

* docs: use slice_by_depth in colored circuit, too

---------

Co-authored-by: Max Rossmannek <[email protected]>
(cherry picked from commit 7c42e3c)

Co-authored-by: Caleb Johnson <[email protected]>
@mrossinek mrossinek deleted the coloring-how-to branch December 19, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable backport potential Label for mergify to open a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants