-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a coloring how-to #30
Conversation
Co-authored-by: Max Rossmannek <[email protected]>
Pull Request Test Coverage Report for Build 10844302431Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@mrossinek I can probably get graphviz installed in the CI envs, but I'm a bit confused why OBP can use graphviz_draw in the notebooks using the same type of dependency specification of rustworkx[graphviz] that I do here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I like this, thanks for putting it together!
Just some nitpicky ideas 👍
* Add a coloring how-to Co-authored-by: Max Rossmannek <[email protected]> * style * lint * Add runtime to notebook deps for fake backends * Get graphviz with rustworkx * fix duplicate * Clean up tutorial * Skip graphviz cells for execution * style :) * Didn't save second metadata change * Evidently one of the tags wasn't checked? *sigh* * peer review * style * that/which pedantry * rephrase * Improve output * Use single quotes * docs: use slice_by_depth in colored circuit, too --------- Co-authored-by: Max Rossmannek <[email protected]> (cherry picked from commit 7c42e3c)
* Add a coloring how-to Co-authored-by: Max Rossmannek <[email protected]> * style * lint * Add runtime to notebook deps for fake backends * Get graphviz with rustworkx * fix duplicate * Clean up tutorial * Skip graphviz cells for execution * style :) * Didn't save second metadata change * Evidently one of the tags wasn't checked? *sigh* * peer review * style * that/which pedantry * rephrase * Improve output * Use single quotes * docs: use slice_by_depth in colored circuit, too --------- Co-authored-by: Max Rossmannek <[email protected]> (cherry picked from commit 7c42e3c) Co-authored-by: Caleb Johnson <[email protected]>
This PR adds a how-to showing how coloring can be used to improve the depth of circuits by more efficiently placing gates.