-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cutting tutorials to send ISA circuits to Qiskit Runtime #500
Conversation
These `close` calls are redundant since Qiskit/qiskit-ibm-runtime#1139.
... in cutting tutorials 1 and 3
Pull Request Test Coverage Report for Build 8290077464Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this. We will only have to do transpilation once at the subcircuit level after #492 is merged, but for now we need to transpile each subexperiment individually before sending off to QPU
"#\n", | ||
"# with Session(backend=\"ibmq_qasm_simulator\") as session:\n", | ||
"# service = QiskitRuntimeService()\n", | ||
"# backend = service.least_busy(operational=True, simulator=False)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can remove the Runtime example in the comments here (and our other tutorials) in a future PR and use a fake backend from qiskit_ibm_runtime. The usage should be the same for the fake backend and real backend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. I opened #511 so we don't lose track of this.
* Remove explicit `session.close()` calls inside context manager These `close` calls are redundant since Qiskit/qiskit-ibm-runtime#1139. * Demonstrate transpiling circuits before sending to Runtime ... in cutting tutorials 1 and 3 * Update tutorial 2 (cutting for depth) * Remove a comma * black * Rename `pm` -> `pass_manager` for clarity (cherry picked from commit bf82d2d)
#512) * Remove explicit `session.close()` calls inside context manager These `close` calls are redundant since Qiskit/qiskit-ibm-runtime#1139. * Demonstrate transpiling circuits before sending to Runtime ... in cutting tutorials 1 and 3 * Update tutorial 2 (cutting for depth) * Remove a comma * black * Rename `pm` -> `pass_manager` for clarity (cherry picked from commit bf82d2d) Co-authored-by: Jim Garrison <[email protected]>
session.close()
, following Allow users to indicate they are done submitting jobs to a session qiskit-ibm-runtime#1139ibmq_qasm_simulator
from cutting documentation (except cutqc docs -- that can wait for Remove uses ofibmq_qasm_simulator
from cutqc tutorials #502)I tested the modified commented out blocks with Qiskit Runtime. The third tutorial currently fails with Runtime because of #452, but that's a separate issue; in fact, it should resolve itself soon once the Sampler supports dynamic circuits.
Saving for subsequent PRs: