Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cutting tutorials to send ISA circuits to Qiskit Runtime #500

Merged
merged 6 commits into from
Mar 25, 2024

Conversation

garrison
Copy link
Member

@garrison garrison commented Mar 11, 2024

I tested the modified commented out blocks with Qiskit Runtime. The third tutorial currently fails with Runtime because of #452, but that's a separate issue; in fact, it should resolve itself soon once the Sampler supports dynamic circuits.

Saving for subsequent PRs:

@garrison garrison added documentation Improvements or additions to documentation cutting QPD-based circuit cutting code labels Mar 11, 2024
@garrison garrison added this to the 0.6.1 milestone Mar 11, 2024
@garrison garrison self-assigned this Mar 11, 2024
@coveralls
Copy link

coveralls commented Mar 11, 2024

Pull Request Test Coverage Report for Build 8290077464

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.541%

Totals Coverage Status
Change from base Build 8179277356: 0.0%
Covered Lines: 2346
Relevant Lines: 2508

💛 - Coveralls

@garrison garrison added the stable backport potential Suitable to be backported to most recent stable branch by Mergify label Mar 12, 2024
@garrison garrison marked this pull request as ready for review March 13, 2024 01:13
Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this. We will only have to do transpilation once at the subcircuit level after #492 is merged, but for now we need to transpile each subexperiment individually before sending off to QPU

"#\n",
"# with Session(backend=\"ibmq_qasm_simulator\") as session:\n",
"# service = QiskitRuntimeService()\n",
"# backend = service.least_busy(operational=True, simulator=False)\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove the Runtime example in the comments here (and our other tutorials) in a future PR and use a fake backend from qiskit_ibm_runtime. The usage should be the same for the fake backend and real backend.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. I opened #511 so we don't lose track of this.

@garrison garrison merged commit bf82d2d into main Mar 25, 2024
11 checks passed
@garrison garrison deleted the runtime-isa-circuits branch March 25, 2024 20:35
mergify bot pushed a commit that referenced this pull request Mar 25, 2024
* Remove explicit `session.close()` calls inside context manager

These `close` calls are redundant since
Qiskit/qiskit-ibm-runtime#1139.

* Demonstrate transpiling circuits before sending to Runtime

... in cutting tutorials 1 and 3

* Update tutorial 2 (cutting for depth)

* Remove a comma

* black

* Rename `pm` -> `pass_manager` for clarity

(cherry picked from commit bf82d2d)
garrison added a commit that referenced this pull request Mar 25, 2024
#512)

* Remove explicit `session.close()` calls inside context manager

These `close` calls are redundant since
Qiskit/qiskit-ibm-runtime#1139.

* Demonstrate transpiling circuits before sending to Runtime

... in cutting tutorials 1 and 3

* Update tutorial 2 (cutting for depth)

* Remove a comma

* black

* Rename `pm` -> `pass_manager` for clarity

(cherry picked from commit bf82d2d)

Co-authored-by: Jim Garrison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cutting QPD-based circuit cutting code documentation Improvements or additions to documentation stable backport potential Suitable to be backported to most recent stable branch by Mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants