Remove unnecessary resets in generate_cutting_experiments
#458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6949706214
💛 - Coveralls |
Closed
3 tasks
caleb-johnson
approved these changes
Nov 27, 2023
| ConsolidateResets(), | ||
| DAGFixedPoint(), | ||
| ], | ||
| do_while=lambda property_set: not property_set["dag_fixed_point"], |
There was a problem hiding this comment.
So you repeat these passes until this condition is False. What exactly triggers this? I haven't come up to speed on how control flow operations work yet.
There was a problem hiding this comment.
The DAGFixedPoint pass sets this property. It's neat; I learned about it only by reading the tests for the RemoveResetInZeroState pass in qiskit.
| Transpiler passes (:mod:`circuit_knitting.utils.transpiler_passes`) | ||
| =================================================================== | ||
|
|
||
| .. automodule:: circuit_knitting.utils.transpiler_passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #452.
I'd still like to swap the tutorial and how-to as suggested in the second point at #452 (comment), but this can be done independently in a follow-up PR.