Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permalinks with API generation for Sphinx 7.2+ #212

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

Eric-Arellano
Copy link
Collaborator

@Eric-Arellano Eric-Arellano commented Oct 19, 2023

Fixes one of the issues in #67, that we weren't removing the permalink in headers with qiskit-ibm-runtime:

screenshot_2023-10-20_at_11 17 25___am_720

This change is because of sphinx-doc/sphinx@7e9a206. Sphinx 7.2 changed the title from "Permalink" to "Link".

Copy link
Member

@frankharkins frankharkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Eric-Arellano Eric-Arellano changed the title Fix permalinks with API generation Fix permalinks with API generation for Sphinx 7.2+ Oct 20, 2023
@Eric-Arellano Eric-Arellano merged commit 510e5a9 into main Oct 20, 2023
3 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/fix-permalinks branch October 20, 2023 15:22
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Fixes one of the issues in
Qiskit#67, that we weren't
removing the permalink in headers with qiskit-ibm-runtime:

![screenshot_2023-10-20_at_11 17
25___am_720](https://github.com/Qiskit/documentation/assets/14852634/4fde70dc-e8c5-424f-9d34-c71cba68501a)

This change is because of
sphinx-doc/sphinx@7e9a206.
Sphinx 7.2 changed the title from "Permalink" to "Link".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants