add how-to-guide on classical feedforward and control flow #198
Conversation
|
The CI complains Can we make this more lenient? I created the notebook with VS Code and it opens in Jupyter Lab. Otherwise, what's an easy way to ensure notebooks pass the linter? |
No, we must have the metadata set for the docs infra to work. I need to improve the instructions though, #200. To fix, open the notebook in text mode in VSCode and scroll to the very bottom of the file to its metadata section - make sure it's metadata for the notebook and not an individual cell. Then add |
There was a problem hiding this comment.
Overall looking great thanks @kevinsung!
I left some comments below, also could you please update the toc so this file will appear in the sidebar, @abbycross or @beckykd or @Eric-Arellano can help you if you don't know how to do this
I will add this to the toc according to our Build nav bar plan, and just FYI it is going to be first in the Build section since the pages above it haven't been published yet. |
|
@javabster I've addressed your comments and updated the toc. |
There was a problem hiding this comment.
The return value of the context manager can be stored and used subsequently as a context manager to create an
elseblock, which is executed whenever the contents of theifblock are not executed.
Is there a way to rewrite this line without saying context manager twice? maybe something like "the measurement outcome of the if statement can be stored and used subsequently as a context manager to create an else block..."
|
other than the small language things above this LGTM 🚀 |
|
I've updated the wording to
and fixed the "clarity" typo. |
Fixes Qiskit#33. That issue mentioned that we would add a warning box on limitations and link to a page on limitations in the run section, which will be created as part of Qiskit#148. In the end I decided to keep this guide self-contained and omit the warning. If we still want to add the warning box, we can do it as part of the latter issue. --------- Co-authored-by: abbycross <[email protected]>
Fixes #33.
That issue mentioned that we would add a warning box on limitations and link to a page on limitations in the run section, which will be created as part of #148. In the end I decided to keep this guide self-contained and omit the warning. If we still want to add the warning box, we can do it as part of the latter issue.