Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce that metadata descriptions are not more than 160 characters #327

Closed
Eric-Arellano opened this issue Nov 10, 2023 · 0 comments · Fixed by #890
Closed

Enforce that metadata descriptions are not more than 160 characters #327

Eric-Arellano opened this issue Nov 10, 2023 · 0 comments · Fixed by #890

Comments

@Eric-Arellano
Copy link
Collaborator

Eric-Arellano commented Nov 10, 2023

Relates to #131. It's bad for SEO to exceed 160 characters.

We should also check that the title != description, which is a common practice. And probably a minimum of 50 characters for the description.

Skip APIs since those are generated.

We should include general tips for how to write good SEO, such as the tips from #131. We could either link to resources like the GitHub issue or directly write the tips.

--

This should simply modify checkMetadata.ts. Similar to our check for missing metadata, we should batch all failing files into a single list and single error message.

@Eric-Arellano Eric-Arellano added this to the 24-01-30 Qiskit 1.0 milestone Nov 10, 2023
github-merge-queue bot pushed a commit that referenced this issue Dec 11, 2023
Closes #200.

Note that we still want to improve this metadata checker to also start
checking some quality things, like that it's <160 characters. But this
is a good first pass. See
#327.

```
      Invalid Jupyter notebook metadata. Every .ipynb file needs to 
      set 'title' and 'description' in the file metadata. You need to
      manually add this metadata. 
      
      For example, if using VSCode, open up the file with the "Open With..." option and then "Text Editor".
      
      Once the file is open in text-mode, scroll down to the bottom of the file for the top-level key "metadata". Be careful that this is the metada for the entire file
      and not a single code block. You should see in the "metadata" section other
      entries like "language_info" and "nbconvert_exporter".

      Finally, add new keys in the "metadata" section for "title" and "description". The
      "title" should be the page title; the "description" should describe the page
      in <160 characters, ideally using some keywords. The description is what
      shows up on Google results. See #131 for some tips. 

      For example:

      "metadata": {
        "description": "Get started using Qiskit with IBM Quantum hardware in this Hello World example",
        "title": "Hello world",
        "celltoolbar": "Raw Cell Format",
        "kernelspec": { ...
      }

      Please fix these files: docs/start/hello-world.ipynb
```

```
      Invalid markdown file metadata. Every .md and .mdx file should start with a metadata block like this:

      ---
      title: Representing quantum computers
      description: Learn about coupling maps, basis gates and backend errors for transpiling
      ---

      The title should be the page title; the description should describe the page
      in <160 characters, ideally using some keywords. The description is what
      shows up on Google results. See #131 for some tips.

      Please fix these files: docs/start/setup-channel.mdx
    ```

---------

Co-authored-by: Arnau Casau <[email protected]>
@Eric-Arellano Eric-Arellano removed this from the 24-02-13 Qiskit 1.0 milestone Jan 11, 2024
@Eric-Arellano Eric-Arellano moved this to In Review in Docs Planning Feb 26, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Docs Planning Feb 26, 2024
frankharkins pushed a commit to frankharkins/documentation that referenced this issue Jul 22, 2024
Closes Qiskit#200.

Note that we still want to improve this metadata checker to also start
checking some quality things, like that it's <160 characters. But this
is a good first pass. See
Qiskit#327.

```
      Invalid Jupyter notebook metadata. Every .ipynb file needs to 
      set 'title' and 'description' in the file metadata. You need to
      manually add this metadata. 
      
      For example, if using VSCode, open up the file with the "Open With..." option and then "Text Editor".
      
      Once the file is open in text-mode, scroll down to the bottom of the file for the top-level key "metadata". Be careful that this is the metada for the entire file
      and not a single code block. You should see in the "metadata" section other
      entries like "language_info" and "nbconvert_exporter".

      Finally, add new keys in the "metadata" section for "title" and "description". The
      "title" should be the page title; the "description" should describe the page
      in <160 characters, ideally using some keywords. The description is what
      shows up on Google results. See Qiskit#131 for some tips. 

      For example:

      "metadata": {
        "description": "Get started using Qiskit with IBM Quantum hardware in this Hello World example",
        "title": "Hello world",
        "celltoolbar": "Raw Cell Format",
        "kernelspec": { ...
      }

      Please fix these files: docs/start/hello-world.ipynb
```

```
      Invalid markdown file metadata. Every .md and .mdx file should start with a metadata block like this:

      ---
      title: Representing quantum computers
      description: Learn about coupling maps, basis gates and backend errors for transpiling
      ---

      The title should be the page title; the description should describe the page
      in <160 characters, ideally using some keywords. The description is what
      shows up on Google results. See Qiskit#131 for some tips.

      Please fix these files: docs/start/setup-channel.mdx
    ```

---------

Co-authored-by: Arnau Casau <[email protected]>
frankharkins pushed a commit to frankharkins/documentation that referenced this issue Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants