-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add annotations to namespace in backend page #295
Merged
wilhelmguo
merged 12 commits into
Qihoo360:master
from
chengyumeng:feature/namespace_annotations
Feb 21, 2019
Merged
Add annotations to namespace in backend page #295
wilhelmguo
merged 12 commits into
Qihoo360:master
from
chengyumeng:feature/namespace_annotations
Feb 21, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g/wayne into feature/namespace_annotations
@chengyumeng 不是要做成类似于高级模式可以完全编辑metadata的形式么? |
@wilhelmguo 在 弹窗中弹出弹窗有问题。然后像 APP 那样元数据是一个框,感觉编辑起来不方便。 |
是需要做成那种像模版编辑一样,跳转一个页面,然后编辑元数据的时候再弹窗 |
@wilhelmguo 你看一下要不要和其他资源的创建编辑统一一下,可以做成页面上可以相互切换的形式,其他的都是有个元数据的栏 |
这个比较特殊,因为要配置配额,直接编辑元数据不太方便,但是做成表单又不太灵活,所以要先把这个实现了 |
…g/wayne into feature/namespace_annotations
wilhelmguo
added
the
kind/enhancement
Categorizes issue or PR as related to enhancement.
label
Feb 20, 2019
chengyumeng
requested review from
wilhelmguo and
BennieMeng
and removed request for
wilhelmguo
February 21, 2019 02:38
wilhelmguo
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
实现了表单中创建 ns 注解的功能
暂未实现高级模式编辑(可能需要较多调整)