Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: misc.cfg #112

Merged
merged 3 commits into from
Oct 29, 2024
Merged

feat: misc.cfg #112

merged 3 commits into from
Oct 29, 2024

Conversation

ChatDisabled
Copy link
Member

Description

Adds a simple misc.cfg to hopefully make server owners more aware of certain convars that are out there and nudge them towards searching around more.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@ChatDisabled ChatDisabled added the enhancement New feature or request label Oct 29, 2024
Copy link
Member

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. It would be more helpful to set the convars to their default values so that server owners can change the values without needing to uncomment.
  2. misc.cfg is too broad a category. I would just put these at the bottom of server.cfg

Just in case, seemed to not like it when set to its default value from limited testing. Can't confirm.
@mafewtm mafewtm merged commit 703725b into main Oct 29, 2024
1 check passed
@Manason Manason deleted the feat-misc_convars branch October 29, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants