fix(server/player) sanitize player name & limit to 50 chars for db constraints #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafewtm
reviewed
Oct 27, 2024
| @@ -425,7 +425,7 @@ function CheckPlayerData(source, playerData) | |||
| if source then | |||
| playerData.source = source | |||
| playerData.license = playerData.license or GetPlayerIdentifierByType(source --[[@as string]], 'license2') or GetPlayerIdentifierByType(source --[[@as string]], 'license') | |||
| playerData.name = GetPlayerName(source) | |||
| playerData.name = string.sub(GetPlayerName(source):gsub('[^%w%s]', ''), 1, 50) | |||
There was a problem hiding this comment.
The DB allows names to be 255 characters as its set to varchar(255). I don't think the player name should be touched what so ever in my opinion.
There was a problem hiding this comment.
Do I have an old version of the SQL, this was ran from the qbx_core resource, sets the "name" to 50.
There was a problem hiding this comment.
I do see this now, my apologies not entirely sure why the database set it to 50 for me.
There was a problem hiding this comment.
nvm I missed this, the player table is altered to set 'name' to varchar(50)
https://github.com/Qbox-project/qbx_core/blob/main/qbx_core.sql#L24-L25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(server/player) sanitize player name, limit to 50 chars for db constraints
Description
Added a
Checklist