Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set current_ to keep invariant in error case #1

Merged
merged 1 commit into from
Mar 28, 2021

Conversation

lmangani
Copy link
Member

The very first time output.Rotate() is called, current_ might be uninitialized. If the open() call fails then, RETURN_IF_ERROR does not set it to a different value. Later calls in Output::Write() will dereference current_ and crash.

The very first time output.Rotate() is called, current_ might be uninitialized.  If the open() call fails then, RETURN_IF_ERROR does not set it to a different value.  Later calls in Output::Write() will dereference current_ and crash.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lmangani lmangani merged commit 84b9bb8 into QXIP:master Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants