Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to run QUARK as a container #85

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Added support to run QUARK as a container #85

merged 1 commit into from
Nov 10, 2023

Conversation

philross
Copy link
Member

@philross philross commented Nov 8, 2023

This PR adds the support to run QUARK as a container.

Next to the Dockerfile and documentation in the README.md and the tutorial.rst also a GitHub workflow was added to build and pushes the image to GitHub packages.

Normally an image is only built for the dev and main branch, but to test this PR, I created an image with the dockerSupport tag that can be tested like:

docker run -it --rm ghcr.io/quark-framework/quark:dockerSupport

At the moment the workflow only builds the image for two platforms: "linux/amd64,linux/arm64".

@philross philross added the enhancement New feature or request label Nov 8, 2023
Copy link
Contributor

@Marvmann Marvmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked for windows. Works fine.

@Marvmann Marvmann merged commit 9e8bb70 into dev Nov 10, 2023
1 of 2 checks passed
@Marvmann Marvmann deleted the dockerSupport branch November 10, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants