Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #24

Open
5 of 9 tasks
szabo137 opened this issue Jun 18, 2024 · 1 comment
Open
5 of 9 tasks

Cleanup #24

szabo137 opened this issue Jun 18, 2024 · 1 comment

Comments

@szabo137
Copy link
Member

szabo137 commented Jun 18, 2024

During the restructuring of QED.jl, some little cosmetic issues were introduced (or copied):

  • check for obsolete dependencies (in deps and extras)
  • Drop usage of Suppressors in the tests and use TestImpl instead.
  • rename algebraic_objects
  • use import Pack and Pack.func(...) = ... instead of using Pack: func and func(...) = ... for implementing an interface.
  • move all import statements to src/QEDcore.jl
  • Drop usage of SimpleTraits.jl (maybe after Refactor: FourMomentum interface QEDbase.jl#59)
  • refactor src/particles/spinors.jl (will be done in a separate issue)
  • reexport base_state (?)
  • remove mul because it is redundant if Base.* is implemented anyway.
@szabo137 szabo137 mentioned this issue Jun 18, 2024
AntonReinhard added a commit that referenced this issue Jul 12, 2024
Add Reexport.jl to the dependencies and use it to reexport QEDbase's
symbols. This is the officially endorsed way to do this
(JuliaLang/julia#1986).

Fixes part of #24
@AntonReinhard
Copy link
Member

As far as I can see there's only one import left, which is import Base: * and I would keep that where it's needed to be less confusing. Directly overloading Base.*() sadly doesn't work, so it has to be imported.
There are also no usings left in src/ outside of QEDcore.jl

AntonReinhard added a commit that referenced this issue Aug 29, 2024
See subtask in #24 , it is actually unused currently anyways.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants