Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist point picker #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Checklist point picker #22

wants to merge 1 commit into from

Conversation

maestroh
Copy link

@maestroh maestroh commented Aug 7, 2012

I've added the point picker to the checklist items. We've started to use your tool at work, and find that it meets most of our needs. We just needed the additional granularity of assigning points to the checklist. I hope you find that this change is up to your standard.

This is my first pull request, and I hope I got it right. Thanks for the great tool.

@loklaan
Copy link

loklaan commented Mar 15, 2013

Was this implemented? I add (2) next to checklist items but it isn't picked up...

@jkaizer
Copy link
Member

jkaizer commented Mar 15, 2013

I believe this not yet included. 

Sent from Mailbox for iPhone

On Fri, Mar 15, 2013 at 8:28 AM, Lochlan Bunn [email protected]
wrote:

Was this implemented? I add (2) next to checklist items but it isn't picked up...

Reply to this email directly or view it on GitHub:
#22 (comment)

@jakecraige
Copy link

This would be an awesome addition if we could get it in. I may look into working on it if the current implementation won't work anymore. I'd love to be able to have a card as more of a "feature" or "epic" and then have a list of all the tasks in checklist and have it automatically add those up to a total

@mgan59
Copy link
Contributor

mgan59 commented Feb 15, 2014

👍

@mgan59
Copy link
Contributor

mgan59 commented Feb 17, 2014

Pulled and tested, does not work at all. Looks like the first breakages involves the listener that triggers the showChecklistItemPointPicker just looking at it I don't believe Trello uses underscores in class names at all.

$(".check-item .check_item_text .edit .edit-controls").live('DOMNodeInserted',showChecklistItemPointPicker);

Would really like to have this functionality in place so will look a little more and see if I can get it patched and ready for a merge.

@mgan59
Copy link
Contributor

mgan59 commented Feb 24, 2014

Status Report

K realized I had a larger problem, hadn't pulled upstream so my merge was totally outdated.

Working from the tip of master I just started completely over. I managed to get the showPointPicker to embed into the .edit-controls of the checklist items so I can select a point value for a given checklist item, but the values aren't aggregating. In my mind, the next step would be each checklist aggregating their totals followed by the card itself aggregating all the checklist totals. I started tracing the code some for calculating specifically the recalcObserver. But I lost momentum after several days away. If someone familiar with the code could maybe just tell me the important lines(#) where I can hook in for aggregating point totals that would help.

Functionality

Also, functionality-wise do we want to make this a feature you enable from the trelloScrum settings? I could see out-of-the-box this may confuse some users if their checklist aggregates are constantly overriding any value they try to manually set on the card. Was also thinking we should have a different colors for the point totals indicating they are from checklists, further have the colors indicate if all checklist items have had points assigned that way you can tell on first glance if all the points have been assign for a card if you are planning based on points.

My branch -
I know my add point picker is a little hacky, will clean it up before sending a PR mgan59@bceb27e

onilton added a commit to onilton/TrelloScrum that referenced this pull request Feb 21, 2015
Heavily inspired by the pull request Q42#22:
Q42#22
But a LOT of changes were necessary to make it work
with current trunk.
@onilton
Copy link

onilton commented Feb 21, 2015

@mgan59 I used your commit as the base to submit a new pull request that tries to accomplish all the things attempted to fullfill in this old pull request.

It was heavily inspired by this pull request (#22) but a LOT of changes were necessary to make it work
with current trunk.

But now you can also:

  • Choose estimated and consumed points in the checklist.
  • Consumed and estimated points are updated in the card title when points are given to checklist items

onilton added a commit to onilton/TrelloScrum that referenced this pull request Feb 22, 2015
This was a mistake of the original code from pull request Q42#22.
We were iterating on pointSeq (Fibonacci numbers). Actually we were
iterating on the indices of this array, so we were stopping at the 9th
item of the list always.
Now we are iterating in all checklists items.
onilton added a commit to onilton/TrelloScrum that referenced this pull request Mar 5, 2015
Heavily inspired by the pull request Q42#22:
Q42#22
But a LOT of changes were necessary to make it work
with current trunk.
onilton added a commit to onilton/TrelloScrum that referenced this pull request Mar 5, 2015
This was a mistake of the original code from pull request Q42#22.
We were iterating on pointSeq (Fibonacci numbers). Actually we were
iterating on the indices of this array, so we were stopping at the 9th
item of the list always.
Now we are iterating in all checklists items.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants