-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checklist point picker #22
base: master
Are you sure you want to change the base?
Conversation
Was this implemented? I add |
I believe this not yet included. On Fri, Mar 15, 2013 at 8:28 AM, Lochlan Bunn [email protected]
|
This would be an awesome addition if we could get it in. I may look into working on it if the current implementation won't work anymore. I'd love to be able to have a card as more of a "feature" or "epic" and then have a list of all the tasks in checklist and have it automatically add those up to a total |
👍 |
Pulled and tested, does not work at all. Looks like the first breakages involves the listener that triggers the
Would really like to have this functionality in place so will look a little more and see if I can get it patched and ready for a merge. |
Status ReportK realized I had a larger problem, hadn't pulled upstream so my merge was totally outdated. Working from the tip of master I just started completely over. I managed to get the showPointPicker to embed into the FunctionalityAlso, functionality-wise do we want to make this a feature you enable from the trelloScrum settings? I could see out-of-the-box this may confuse some users if their checklist aggregates are constantly overriding any value they try to manually set on the card. Was also thinking we should have a different colors for the point totals indicating they are from checklists, further have the colors indicate if all checklist items have had points assigned that way you can tell on first glance if all the points have been assign for a card if you are planning based on points. My branch - |
@mgan59 I used your commit as the base to submit a new pull request that tries to accomplish all the things attempted to fullfill in this old pull request. It was heavily inspired by this pull request (#22) but a LOT of changes were necessary to make it work But now you can also:
|
This was a mistake of the original code from pull request Q42#22. We were iterating on pointSeq (Fibonacci numbers). Actually we were iterating on the indices of this array, so we were stopping at the 9th item of the list always. Now we are iterating in all checklists items.
This was a mistake of the original code from pull request Q42#22. We were iterating on pointSeq (Fibonacci numbers). Actually we were iterating on the indices of this array, so we were stopping at the 9th item of the list always. Now we are iterating in all checklists items.
I've added the point picker to the checklist items. We've started to use your tool at work, and find that it meets most of our needs. We just needed the additional granularity of assigning points to the checklist. I hope you find that this change is up to your standard.
This is my first pull request, and I hope I got it right. Thanks for the great tool.