-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] srFGW barycenters #659
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #659 +/- ##
==========================================
+ Coverage 96.67% 96.71% +0.03%
==========================================
Files 85 86 +1
Lines 16956 17148 +192
==========================================
+ Hits 16392 16584 +192
Misses 564 564 |
rflamary
reviewed
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
semirelaxed_fgw_barycenters
with similar API thanfgw_barycenters
gromov/_utils
:update_barycenter_structure
andupdate_barycenter_feature
which extend/relax several aspects of existing functions for gw barycenters (update_square_loss
,update_kl_loss
andupdate_feature_matrix
--> removed), seeking for potential use in other variants than gw, e.g now used with sr(F)GW but could be also used with P(F)GW and U(F)GW.Motivation and context / Related issue
How has this been tested (if it applies)
PR checklist