Improve CI / testing #754
Merged
Improve CI / testing #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
commented
Nov 14, 2018
blueyed
force-pushed
the
extras-testing
branch
from
8738509
to
c4d1483
Compare
blueyed
force-pushed
the
extras-testing
branch
from
3e1f0db
to
96e040a
Compare
waylan
requested changes
Nov 14, 2018
There was a problem hiding this comment.
I have comments on a number of things below. For the most part, I don't see how any of this improves anything. To me it mostly seems like changes for changes sake. Some explanations of the reasoning might help.
Regardless, the things I call out need to be fixed.
This centralized testing requirements and allows for `pip install -e .[testing]` etc. pytidylib is kept separate according to https://github.com/Python-Markdown/markdown/pull/754/files#r233561159.
blueyed
force-pushed
the
extras-testing
branch
from
96e040a
to
959690d
Compare
waylan
approved these changes
Nov 15, 2018
waylan
reviewed
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This centralized testing requirements and allows for
pip install -e .[testing]etc.