-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(tests): Resolve Ansible Lint warnings and fix Molecule tests on GitHub Actions #202
Conversation
… mention build cluster
For templated vars in task name
Use separate CI job step to run linting instead.
Subject to change
Suspect issues with Molecule tests are related to cgroups v2.
Ready for PR @onedr0p 🙂 |
Great work here @dbrennand . Thanks! I need to bug @xanmanning and see what is needed to cut a release. |
No worries 🙂 - Glad I could help 😄 Help us @xanmanning, you're our only hope! 😆 🙂 |
For now with we could pin our galaxy config to the hash... eg.
|
Apologies, been living under a rock for a few months. Done some releasin' Thanks for the hard work @dbrennand and @onedr0p ! |
TITLE
Summary
Fix Ansible Lint warnings and resolve Molecule tests failing.
Molecule v5.0.0 dropped support for
lint
, see ansible/molecule#3802 so I created a separate CI job for runningyamllint
andansible-lint
.To fix the molecule tests, I've removed the
lint
section andlint
test scenario from eachmolecule.yml
file. Furthermore, the Molecule tests were failing, and I suspect this was becauseubuntu-latest
was updated to Ubuntu 22.04 sometime ago and cgroups v2 was causing all tests to fail. I saw similar issues in dbrennand/ansible-role-caddy-docker@2d23b79 and I resolved by dropping toubuntu-20.04
to get the tests in a working state again.Issue type
Test instructions
N/A
Acceptance Criteria
Additional Information