change default behavior in appsi to not care where variables live #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2903 +/- ##
==========================================
+ Coverage 87.81% 87.82% +0.01%
==========================================
Files 770 770
Lines 89626 89641 +15
==========================================
+ Hits 78701 78728 +27
+ Misses 10925 10913 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
emma58
approved these changes
Jul 17, 2023
pyomo/contrib/appsi/base.py
Outdated
Comment on lines
1463
to
1467
| # this has to be done after the objective in case the | ||
| # old objective uses old variables | ||
| timer.start('vars') | ||
| self.remove_variables(old_vars) | ||
| timer.stop('vars') |
There was a problem hiding this comment.
Just to make sure I'm understanding, it has to be after constraints for the same reason, right? (It just already was.)
There was a problem hiding this comment.
Oh, good point. Yes.
There was a problem hiding this comment.
I'll update the comment
Haha, good! |
This was referenced Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2888.
Summary/Motivation:
This PR
updatewhere an error was raised when removing variables that were used in the old objective but not the new objective.only_child_vars=Trueandonly_child_vars=False. This is the flag that controls how variables are gathered (by traversing the model or from the active constraints/objective).Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: