Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizing github actions naming #1323

Merged
merged 3 commits into from
Mar 4, 2020

Conversation

jsiirola
Copy link
Member

@jsiirola jsiirola commented Mar 3, 2020

Fixes #N/A

Summary/Motivation:

This standardizes the naming for the various GitHub Actions drivers.

Changes proposed in this PR:

  • standardize test names as continuous-integration/github/{push,pr} / [mpi/]{linux,osx,win}/py{N}.{M}

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@jsiirola jsiirola requested a review from mrmundt March 3, 2020 22:45
Copy link
Contributor

@mrmundt mrmundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new workflow to me. What value is it adding?

@jsiirola
Copy link
Member Author

jsiirola commented Mar 3, 2020

@mrmundt: I assume you are referring to the parallel workflow? It came in as part of #1285, where @michaelbynum wanted to be able to test some things within mpi4py. We tried to (efficiently, correctly) launch MPI from within nose, but in the end it ended up being easier to to launch nose within MPI and just run the subset of tests that required MPI. A future PR will introduce an "mpi" category and then categorize the tests that are currently called out explicitly. Another open todo is to see if we can't get the MPI driver closer to the regular driver.

...having just written all of this, it occurs to me that we should change the "parallel" name to just "mpi".

@blnicho
Copy link
Member

blnicho commented Mar 3, 2020

Can I tack on one more change to this PR? Could we update our actions to use:

- uses: actions/checkout@v2

This should fix the retrying Github Actions issue.

@blnicho
Copy link
Member

blnicho commented Mar 4, 2020

Since this only impacts the Github Actions builds (which have all passed) I'm going to go ahead and merge this.

@blnicho blnicho merged commit 0571557 into Pyomo:master Mar 4, 2020
@jsiirola jsiirola deleted the github-actions-naming branch March 4, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants