-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set the minimum supported version at py35 #3547
Conversation
7bf69ab
to
5e7f4e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good so far, with a couple of corrections.
I will scan the docs and make a PR to your branch.
By dropping 3.5, we need to revise our Python support policy. But first the wording is kind of klunky.
I think the intent was:
And finally, perhaps add a sentence?
|
I found this while scanning for 3.5. Candidate for removal? pyramid/src/pyramid/config/actions.py Lines 562 to 567 in 497e667
|
I’m fine with keeping 3.5 if we have docs around it. There aren’t 3.6 specific features yet. If we were doing more with typing then there might be good reason.
|
The docs don't need 3.5. There were a couple mentions that we support 3.5, and that was it. When I last updated the docs, I bumped up almost everything to 3.7. I think the choice is whether you want to open the door to 3.6 features or have 3.5 block their implementation. |
Update docs and setup.py, remove py35, py36, add py38
Co-Authored-By: Steve Piercy <[email protected]>
I don't really want to make an exception for 3.6. If our policy is to support 3.5 then we should support 3.5. |
the failing CI is around an unrelated issue with cookiecutter |
I could use some help finishing this out. Need to track down other places (probably in the docs and tutorials) that python versions are referenced.