add execution policy to pyramid request processing diagrams #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is really nice to have this diagram. I wonder if placing name of current stage of processing in the request object would have any use? |
|
@piotr-dobrogost perhaps. Can you describe a specific example? The diagram is pretty dense as it is. If there were to be any additional information presented, I would have to research ways of including tool tips or raw HTML with Sphinx. |
|
Well, I was talking about changes in source code not diagram. What I had in mind is on start of each phase of processing shown on the diagram to tag request object with a name of the phase. This would allow to inspect current phase when for example exception in thrown. In other words this would allow to map any place in source code with the specific phase from the diagram. |
mmerickel
added a commit
that referenced
this pull request
May 2, 2017
This was referenced Jun 26, 2017
This was referenced Jul 10, 2017
This was referenced Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.