migrate pyramid to use plaster #2985
Conversation
|
What's the milestone/target version for these items? |
Also ensure that each script is invoking setup_logging.
mmerickel
changed the title
|
At least for now I've updated pyramid to depend on plaster_pastedeploy which makes this PR bw-compatible. Shipping pyramid without any specific config-file loader is something we can debate. It's a pretty substantial amount of stuff, even just in core, that needs fixes if we rip out that dependency. |
|
I think I'm done with this for now, pending review. I updated a couple locations in the documentation but tried not to make too big of a deal about it at this time. It's a new feature and there's no sense in jamming it down people's throats so I just tried to give some clues that pastedeploy could be replaced. |
CHANGES.txt
Outdated
| and ``pshell``, as well as the ``pyramid.paster.bootstrap`` function | ||
| is now replaceable thanks to a new dependency on | ||
| `plaster <http://docs.pylonsproject.org/projects/plaster/en/latest/>`. | ||
|
|
There was a problem hiding this comment.
rst links require a trailing underscore:
`label <link>`_There was a problem hiding this comment.
Thanks I pushed some changes.
CHANGES.txt
Outdated
| The first library to use this feature is | ||
| `pyramid_retry | ||
| <http://docs.pylonsproject.org/projects/pyramid-retry/en/latest/>`. | ||
|
|
CHANGES.txt
Outdated
| objects before they enter rest of the pipeline. This means for a given | ||
| request that the policy may create more than one request for retry | ||
| purposes. See https://github.com/Pylons/pyramid/pull/2964 | ||
| objects before they enter rest of the pipeline. This means for a single |
docs/glossary.rst
Outdated
| @@ -366,6 +366,14 @@ Glossary | |||
| :term:`WSGI` components together declaratively within an ``.ini`` | |||
| file. It was developed by Ian Bicking. | |||
|
|
|||
| plaster | |||
| `plaster <http://docs.pylonsproject.org/projects/plaster/en/latest/>` is | |||
docs/narr/paste.rst
Outdated
| Alternative Configuration File Formats | ||
| -------------------------------------- | ||
|
|
||
| It is possible to use different file formats with :app:`Pyramid` if you do not like :term:`PasteDeploy`. Under the hood all command-line scripts such as ``pserve`` and ``pshell`` pass the ``config_uri`` (e.g. ``development.ini``, ``production.ini``, etc) to the :term:`plaster` library which performs a lookup for an appropriate parser. For ``.ini`` files it uses PasteDeploy but you can register your own configuration formats that plaster will find instead. |
There was a problem hiding this comment.
(for example, development.ini or production.ini)
There was a problem hiding this comment.
What's wrong with e.g.? It's not wrong and from a quick grep of our sources it's used in like 266 spots already.
There was a problem hiding this comment.
- Many style guides use plain English over the Latin abbreviation—"for example" is preferred over "e.g.", "in other words" and "that is" over "i.e.", and "and so on" over "etc.". Reasons include:
- the intention is clearer
- avoids misuse of the abbreviations, usually due to the lack of knowledge of Latin
- has a less erudite tone
- easier to translate
- The use of "e.g." with "etc." in the same phrase is redundant.
- If "e.g." or "i.e." must be used, then they are followed normally by a comma in American english, and confined within parentheses.
Eventually I would like to replace Latin abbreviations with common American english in the narrative documentation so that it reads smoother.
mmerickel
dismissed
stevepiercy’s stale review
I don't intend to change the english words used at this time.
|
I forgot to comment on this, thanks Github UI. 👍 glad to see this happen :D. |
Update cookiecutters to depend on plaster_pastedeploy.Fixes #2419, #1394.