allow prepare/bootstrap to be used as a context manager #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.assertEqual(pushed['registry'], registry) | ||
| self.assertEqual(pushed['request'].registry, registry) | ||
| self.assertEqual(root.a, (request,)) | ||
| info['closer']() |
There was a problem hiding this comment.
Possibly add a comment that you are calling closer here manually to clean up, before replacing it with a testable closer?
Also, why not just have your new closer call the original closer instead?
There was a problem hiding this comment.
Sure, I will fix this to be more clear.
|
LGTM. |
mmerickel
force-pushed
the
feature/with-bootstrap
branch
from
b832c65 to
b36dd80
Compare
mmerickel
added a commit
that referenced
this pull request
Sep 4, 2016
This was referenced Jan 22, 2017
This was referenced Jun 26, 2017
This was referenced Jul 10, 2017
This was referenced Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1822