Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This shows the correct view when a class and attr is involved. #2687

Merged
merged 2 commits into from
Jul 8, 2016

Conversation

sontek
Copy link
Member

@sontek sontek commented Jul 6, 2016

No description provided.

@sontek
Copy link
Member Author

sontek commented Jul 6, 2016

Before this change:

class_based_view           /classes                test_pyramid_apps.standard_views.ClassBasedView             POST

and after:

class_based_view           /classes                test_pyramid_apps.standard_views.ClassBasedView.awesome_attr    POST

@stevepiercy
Copy link
Member

Nice.

For completeness, should either of these be updated?

Also a change log entry?

@stevepiercy stevepiercy closed this Jul 6, 2016
@stevepiercy stevepiercy reopened this Jul 6, 2016
@stevepiercy
Copy link
Member

Sorry, my bad aim on clicking buttons.

@sontek
Copy link
Member Author

sontek commented Jul 6, 2016

@stevepiercy Nope, the docs are accurate, there was just this tiny little bug when you used a class + attr, this is how it should have worked from the beginning :)

@stevepiercy
Copy link
Member

@sontek LGTM.

Should this bug fix be backported to 1.7 and 1.6, along with change log entries?

@sontek
Copy link
Member Author

sontek commented Jul 6, 2016

@stevepiercy Yeah, I think it'd be a great candidate for a backport

@mmerickel
Copy link
Member

LGTM. This feature is fine to be backported if you want to submit the PRs and changelog entries for them.

@stevepiercy stevepiercy merged commit 474d4a8 into Pylons:master Jul 8, 2016
stevepiercy added a commit to stevepiercy/pyramid that referenced this pull request Jul 8, 2016
@stevepiercy stevepiercy self-assigned this Jul 8, 2016
@stevepiercy stevepiercy added this to the 1.7.1 milestone Jul 8, 2016
@stevepiercy
Copy link
Member

I'll do backports tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants