disable csrf checking on all exception views unless explicitly turned on #2517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case: User turns on auto csrf checks and registers exception views.
Issue: User must remember to turn off csrf checks on exception views or they will raise csrf errors instead of handling the original exception.
Solution in this PR: Disable csrf checks on exception views by default.
Control: User can still turn on csrf checks on exception views if they really want by setting
require_csrf=True
explicitly on the exception view.Basically the csrf checks on exception views are too strict causing inadvertent raising of
BadCSRFToken
exceptions while handling the original exception resulting in the new csrf exception being propagated out of pyramid and up the middleware chain.ping @dstufft @bertjwregeer