Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration is changing the settings parameter object #2958

Closed
Natim opened this issue Feb 16, 2017 · 1 comment
Closed

Configuration is changing the settings parameter object #2958

Natim opened this issue Feb 16, 2017 · 1 comment

Comments

@Natim
Copy link

Natim commented Feb 16, 2017 •
edited
Loading

This is a regression from Pyramid 1.7.

.venv/lib/python3.5/site-packages/pyramid/config/__init__.py:329: in __init__
    exceptionresponse_view=exceptionresponse_view,
.venv/lib/python3.5/site-packages/pyramid/config/__init__.py:367: in setup_registry
    self._set_settings(settings)
.venv/lib/python3.5/site-packages/pyramid/config/settings.py:9: in _set_settings
    settings = Settings(mapping)
.venv/lib/python3.5/site-packages/pyramid/config/settings.py:59: in Settings
    d.update(**kw)

We should copy or copy.deepcopy the settings object to prevent this.
This was referenced Feb 16, 2017
Merged
Merged
Natim pushed a commit to Kinto/kinto that referenced this issue Feb 16, 2017
With Pyramid 1.8 the settings object is updated.
396a990 
Refs: Pylons/pyramid@d358511#diff-ddc4bbaedfeb2dbe635f7eb7907b98d0L117
Refs: Pylons/pyramid#2958
@mmerickel
Copy link
Member

Fixed in #2959. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Natim @mmerickel