-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented attachments in Webhook.edit_message and WebhookMessage.edit #712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing files
to this without attachments
would replace all of the message's attachments with the files passed.
Other than that, looks fine.
As shown in the Discord server discussion, given that the payload never adds the parameter attachment in such cases, it shouldn't have such issue given how the API works, instead it'd simply append files in the message. See Documentation as Reference The replacement would only happen if the user provides a list of attachments, even if it's zero length. |
This is the future plan of discord.
For now correct. |
…or further API compatibility
Since this is existing API functionality that we currently lack, I'm good with merging this now and then updating for API v10 once that arrives. |
Summary
This allows webhooks to be able to edit attachments according to the implementation in Discord's documentation
Checklist
type: ignore
comments were used, a comment is also left explaining why