-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix incorrect documentation about discord.Option.autocomplete
#2265
Conversation
I'll add the changelog in a sec |
I accidentally forgot to change the title, but I fixed that now |
discord.Option.autocomplete
discord.Option.autocomplete
discord.Option.autocomplete
minor typo fix |
Head branch was pushed to by a user without write access
waaait so if I change something, it dismisses reviews from before?! I guess that makes sense though |
Changed vaugeness Signed-off-by: Blue-Robin-Taken <[email protected]>
Co-authored-by: plun1331 <[email protected]> Signed-off-by: Blue-Robin-Taken <[email protected]>
Co-authored-by: plun1331 <[email protected]> Signed-off-by: Lala Sabathil <[email protected]>
Lol I forgot I made this PR, sorry bout that. School and stuff got me busy. |
All good, we want to clean up stuff |
Would setting [:class: |
i don't think so since any is not truly valid |
@NeloBlivion thoughts? |
I'll dive deeper into the actual code to see what the real class is in the meantime |
The docs right now currently say: Accepts an iterable of :class: |
Co-authored-by: UK <[email protected]> Signed-off-by: Blue-Robin-Taken <[email protected]>
Github asks me why I dismiss. Meow meow I'm just a silly cat.
Should I also change the: |
Hmm I'm unsure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, @NeloBlivion approve if u agree :3
That was my first PR that merged to a repo that wasn't from a school club & is public |
gg's xD |
…Pycord-Development#2265) Signed-off-by: Blue-Robin-Taken <[email protected]> Signed-off-by: Lala Sabathil <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: plun1331 <[email protected]> Co-authored-by: Lala Sabathil <[email protected]> Co-authored-by: NeloBlivion <[email protected]>
Summary
This PR rephrases attr description in docs because it does not allow for string iterables.
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.