Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ScheduledEvent.creator_id returning incorrect type #2162

Merged
merged 6 commits into from
Jul 4, 2023
Merged

fix: ScheduledEvent.creator_id returning incorrect type #2162

merged 6 commits into from
Jul 4, 2023

Conversation

JustaSqu1d
Copy link
Member

@JustaSqu1d JustaSqu1d commented Jul 3, 2023 •
edited by Dorukyum
Loading

Summary

#2160

Technically, not incorrect, but inconsistent with the rest of the library.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@JustaSqu1d JustaSqu1d requested a review from a team as a code owner July 3, 2023 16:32
@pullapprove4 pullapprove4 bot requested a review from CodeWithSwastik July 3, 2023 16:32
@pullapprove4 pullapprove4 bot requested a review from ChickenDevs July 3, 2023 16:32
@JustaSqu1d JustaSqu1d requested a review from Dorukyum July 3, 2023 16:32
@JustaSqu1d JustaSqu1d added bug Something isn't working status: awaiting review Awaiting review from a maintainer python labels Jul 3, 2023
Dorukyum
Dorukyum previously requested changes Jul 3, 2023
View reviewed changes
discord/scheduled_events.py Outdated Show resolved Hide resolved
@JustaSqu1d @Dorukyum
Update discord/scheduled_events.py
f14185c 
Co-authored-by: Dorukyum <[email protected]>
Signed-off-by: JustaSqu1d <[email protected]>
@JustaSqu1d JustaSqu1d added status: in progress Work in Progess and removed status: awaiting review Awaiting review from a maintainer labels Jul 3, 2023
@JustaSqu1d JustaSqu1d added status: awaiting review Awaiting review from a maintainer and removed status: in progress Work in Progess labels Jul 3, 2023
@JustaSqu1d JustaSqu1d requested a review from Dorukyum July 3, 2023 17:11
@JustaSqu1d JustaSqu1d requested review from Lulalaby and removed request for CodeWithSwastik July 3, 2023 18:53
Lulalaby
Lulalaby requested changes Jul 3, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Dorukyum @Lulalaby
Update CHANGELOG.md
af76f43 
Co-authored-by: Lala Sabathil <[email protected]>
Signed-off-by: Dorukyum <[email protected]>
@Lulalaby Lulalaby enabled auto-merge (squash) July 4, 2023 16:40
@Lulalaby Lulalaby merged commit d9a8a42 into Pycord-Development:master Jul 4, 2023
@honzajavorek
Copy link
Contributor

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Middledot Middledot Middledot approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@ChickenDevs ChickenDevs Awaiting requested review from ChickenDevs

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

Assignees
No one assigned
Labels
bug Something isn't working status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JustaSqu1d @honzajavorek @Lulalaby @Dorukyum @Middledot