-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing delete_after parameter #2156
Merged
Lulalaby
merged 3 commits into
Pycord-Development:master
from
Seltsamsel:fix_missing_delete_after_overload
Jun 30, 2023
Merged
fix: add missing delete_after parameter #2156
Lulalaby
merged 3 commits into
Pycord-Development:master
from
Seltsamsel:fix_missing_delete_after_overload
Jun 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lulalaby
approved these changes
Jun 30, 2023
Lulalaby
requested review from
JustaSqu1d
and removed request for
FrostByte266 and
Middledot
June 30, 2023 11:54
Lulalaby
requested changes
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog
JustaSqu1d
suggested changes
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^
auto-merge was automatically disabled
June 30, 2023 12:45
Head branch was pushed to by a user without write access
Lulalaby
approved these changes
Jun 30, 2023
Dorukyum
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a typing error when doing something like
I guess when the
delete_after
parameter was added it was simply forgotten in the overloads.Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.