fix: always set Guild._member_count #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2145 +/- ##
==========================================
+ Coverage 33.86% 33.87% +0.01%
==========================================
Files 109 109
Lines 22361 22353 -8
==========================================
Hits 7573 7573
+ Misses 14788 14780 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
|
Please add a changelog entry. |
Lulalaby
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, if a guild's
member_countwasn't provided from the API (e.g. when usingfetch_guild) the_member_countattribute was never set. This makes sure it's set regardless, and adjust other functions in the library to make use of this instead of usinggetattror try/except.Fixes #2136
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.