feat!: one time event listeners #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustaSqu1d
added
changelog needed
good first issue
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1957 +/- ##
==========================================
+ Coverage 33.32% 33.33% +0.01%
==========================================
Files 97 97
Lines 18901 18891 -10
==========================================
- Hits 6298 6297 -1
+ Misses 12603 12594 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Lulalaby
requested changes
Mar 4, 2023
Lulalaby
changed the title
Signed-off-by: Om <[email protected]>
for more information, see https://pre-commit.ci
Lulalaby
previously approved these changes
Mar 4, 2023
auto-merge was automatically disabled
March 25, 2023 07:33
Head branch was pushed to by a user without write access
for more information, see https://pre-commit.ci
Lulalaby
approved these changes
Mar 25, 2023
ChickenDevs
approved these changes
Mar 25, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #1940 and reimplements one time event listeners using
@client.listen(once=True).Breaking change for master branch. The code this pr breaks isn't released as of making this pr, but merged with master branch.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.