-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: images sending as 0 bytes in paginator if sent as io.BytesIO
#1881
fix: images sending as 0 bytes in paginator if sent as io.BytesIO
#1881
Conversation
This fixes a bug where if a page is viewed more than once, the image wouldn't be displayed except the first time. Signed-off-by: Yaakov Schlachter <[email protected]>
Signed-off-by: Yaakov Schlachter <[email protected]>
for more information, see https://pre-commit.ci
Please stick to to the commit conventions |
Signed-off-by: Yaakov Schlachter <[email protected]>
for more information, see https://pre-commit.ci
I apologize, fixed the PR title. Unfortunately, can't change the commit titles of the individual commits. |
That's fine, we squash per default, just the pr title is important |
Head branch was pushed to by a user without write access
Co-authored-by: Lala Sabathil <[email protected]> Signed-off-by: Yaakov Schlachter <[email protected]>
io.BytesIO
Currently working with @BobDotCom to actually get the best fix possible across the whole framework, instead of a local fix to this function. My code will be deprecated then. |
does this works now @BobDotCom |
Apart from my suggested change, this has been tested and should be ready. |
Co-authored-by: plun1331 <[email protected]> Signed-off-by: Yaakov Schlachter <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: BobDotCom <[email protected]>
for more information, see https://pre-commit.ci
Summary
This fixes a bug where if a page is viewed more than once, the image wouldn't be displayed except the first time.
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.