feat!: add missing embedded activities #1859
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: BobDotCom <[email protected]>
Co-authored-by: BobDotCom <[email protected]>
JustaSqu1d
changed the title
Co-authored-by: BobDotCom <[email protected]> Signed-off-by: JustaSqu1d <[email protected]>
|
Maybe a second changelog entry should be added under the "Removed" section to note that there were also values removed? |
for more information, see https://pre-commit.ci
What about also adding something under the "Changed" section to note the activities' names that were changed? Should I remove the changelog entry in "Added" and "Removed" and put it under "Changed"? |
Lulalaby
changed the title
|
@Lulalaby No, this is a breaking change. It changes the names of |
JustaSqu1d
changed the title
If there were only changes and additions, that would be best |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1859 +/- ##
==========================================
+ Coverage 33.21% 33.27% +0.05%
==========================================
Files 96 96
Lines 18680 18695 +15
==========================================
+ Hits 6205 6220 +15
Misses 12475 12475
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Adding "changed" and "removed" change-log categories entries
JustaSqu1d
added
status: awaiting review
Co-authored-by: BobDotCom <[email protected]> Signed-off-by: JustaSqu1d <[email protected]>
Summary
Adds missing activities. Source of information: https://gist.github.com/GeneralSadaf/42d91a2b6a93a7db7a39208f2d8b53ad
This PR also renames activities that have changed names.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.