Add View.get_item shortcut method #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lulalaby
previously approved these changes
Oct 1, 2022
BobDotCom
reviewed
Oct 1, 2022
Co-authored-by: BobDotCom <[email protected]>
auto-merge was automatically disabled
October 1, 2022 03:43
Head branch was pushed to by a user without write access
BobDotCom
added
status: awaiting review
BobDotCom
previously approved these changes
Oct 1, 2022
Ombucha
suggested changes
Oct 1, 2022
auto-merge was automatically disabled
October 1, 2022 12:03
Head branch was pushed to by a user without write access
BobDotCom
approved these changes
Oct 1, 2022
Dorukyum
approved these changes
Oct 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a method to get an item from a View by its
custom_id.This is ultimately just a shortcut to
utils.get, however it appears to be a rather common use case and as such is implemented for convenience.Information
Checklist
type: ignorecomments were used, a comment is also left explaining why.