Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy webhooks and interactions #1655

Merged
merged 4 commits into from
Sep 30, 2022
Merged

Proxy webhooks and interactions #1655

merged 4 commits into from
Sep 30, 2022

Conversation

BobDotCom
Copy link
Member

Summary

This PR updates webhooks and interactions to support proxies.
Fixes #696

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@BobDotCom BobDotCom self-assigned this Sep 30, 2022
@BobDotCom BobDotCom added this to the v2.2 milestone Sep 30, 2022
@BobDotCom BobDotCom enabled auto-merge (squash) September 30, 2022 04:20
@BobDotCom
Copy link
Member Author

Note: sync webhooks are not included in this PR. They aren't used by interactions, so therefore don't need to be passed the params from client like async webhooks. However, it might be deemed beneficial in the future to add these params to sync webhooks for parity. If this is desired, it can take place in a separate PR/Issue.

@BobDotCom BobDotCom added bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer feature Implements a feature labels Sep 30, 2022
plun1331
plun1331 previously approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yeah it looks good

ChickenDevs
ChickenDevs previously approved these changes Sep 30, 2022
View reviewed changes
Dorukyum
Dorukyum requested changes Sep 30, 2022
View reviewed changes
discord/interactions.py Outdated Show resolved Hide resolved
discord/webhook/async_.py Outdated Show resolved Hide resolved
@BobDotCom BobDotCom dismissed stale reviews from ChickenDevs and plun1331 via faf2bd8 September 30, 2022 19:25
@BobDotCom BobDotCom merged commit 1d16236 into master Sep 30, 2022
@BobDotCom BobDotCom deleted the webhook-proxy branch September 30, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChickenDevs ChickenDevs ChickenDevs approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

@Lulalaby Lulalaby Awaiting requested review from Lulalaby

@Middledot Middledot Awaiting requested review from Middledot

@plun1331 plun1331 Awaiting requested review from plun1331

Assignees

@BobDotCom BobDotCom

Labels
bug Something isn't working feature Implements a feature priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
Pycord Releases
Status: Done
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.

Interaction responses don't respect client proxy settings
4 participants
@BobDotCom @plun1331 @Dorukyum @ChickenDevs