Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Enum options breaking again & wrong typing import #1541

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Fix Enum options breaking again & wrong typing import #1541

merged 1 commit into from
Aug 1, 2022

Conversation

Middledot
Copy link
Member

@Middledot Middledot commented Aug 1, 2022 •
edited
Loading

Summary

Fixes enum options breaking because of from_datatype

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Middledot Middledot added the bug Something isn't working label Aug 1, 2022
@Lulalaby Lulalaby enabled auto-merge (rebase) August 1, 2022 16:19
@Lulalaby
Copy link
Member

Lulalaby commented Aug 1, 2022

Tested?

@Middledot
Copy link
Member Author

yeah I forgot to put the tick

@Lulalaby Lulalaby requested a review from Dorukyum August 1, 2022 16:25
Dorukyum
Dorukyum approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll trust you with testing all cases

@Lulalaby Lulalaby merged commit fde4ded into Pycord-Development:master Aug 1, 2022
@Middledot Middledot deleted the enum-fix-go-brr branch August 1, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Middledot @Lulalaby @Dorukyum