Set store=False as default in load_extension(s) #1520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
store=False
the default inload_extension
/load_extensions
, which keeps the behaviour inline with previous versions.Summary
With #1423, extension loading was reworked to allow loading entire folders at once. This is a very convenient addition, however it introduced the
store
kwarg which decides whetherload_extension
will raise an error or not if a cog fails to load.In the past
load_extension
has always raised an error when this happens, however with this PR the default has been set asstore=True
, which instead stores the error in a dict for the user to parse themselves. While this technically isn't a breaking change since it still functions, the behaviour is different enough from before to cause confusion with users who updated: without setting thestore
kwarg, cogs that have errors will appear to load correctly if you haven't accounted for the change. Neither was this change made note of at all in any update notes.As such, I believe it'd be more appropriate for
store=False
to be the default to be inline with previous behaviorr.Information
Checklist
type: ignore
comments were used, a comment is also left explaining why.